diff options
author | Holger Hans Peter Freyther <zecke@selfish.org> | 2013-03-16 22:05:31 +0100 |
---|---|---|
committer | Harald Welte <laforge@gnumonks.org> | 2013-03-17 10:40:26 +0100 |
commit | 6cdf70598ab71bad6b1aff95b9be9d972e581747 (patch) | |
tree | 8c01158cf1b5f92ee836a668ec5a50b526df66e6 /include/common | |
parent | 68a9cd68aab77ac8f3951b1e809bb4310490db2c (diff) |
wavecom: Fix unaligned memory access and silent stack corruption
The parameters were uint16_t and we asked the libc to make a
store of uint32_t. So 16bit were written to the wrong part of
the struct and on ARM this is causing unaligned memory access.
Use the %hx to make a uint16_t store and avoid the above issue.
GDB
#0 0x4d4d0a20 in _IO_vfscanf () from /lib/libc.so.6
(gdb) bt
#0 0x4d4d0a20 in _IO_vfscanf () from /lib/libc.so.6
#1 0x4d4d5d54 in __isoc99_vsscanf () from /lib/libc.so.6
#2 0x4d4d5cd0 in __isoc99_sscanf () from /lib/libc.so.6
#3 0x400a597c in ?? () from /usr/lib/gsmd/libgsmd-vendor_wavecom.so
Cannot access memory at address 0x3
Clang:
vendor_wavecom.c:114:21: warning: format specifies type 'unsigned int *' but the argument has
type 'u_int16_t *' (aka 'unsigned short *') [-Wformat]
sscanf(tok, "%x", &aux->u.cell_info.ci);
~~ ^~~~~~~~~~~~~~~~~~~~
%hx
Diffstat (limited to 'include/common')
0 files changed, 0 insertions, 0 deletions